rpc/grpcclientidentity: remove hard-coded deadline in listener adatper causing crash

Verified once again that grpc.DialContext is indeed non-blocking.
However, it checks in a defer stmt that the passed dial is not ctx.Done().
That is highly unusual if the dial is non-blocking.
But it might still happen, maybe because of machine suspend during the function call and before the defer stmt is executed.

panic:
context deadline exceeded
goroutine 49 [running]:
github.com/zrepl/zrepl/rpc/grpcclientidentity/grpchelper.ClientConn(0x1906ea0, 0xc0003ea1e0, 0x1921620, 0xc0002da660, 0x0)
        /gopath/src/github.com/zrepl/zrepl/rpc/grpcclientidentity/grpchelper/authlistener_grpc_adaptor_wrapper.go:49 +0x38c
github.com/zrepl/zrepl/rpc.NewClient(0x1906f00, 0xc0002d60f0, 0x1921620, 0xc0002da640, 0x1921620, 0xc0002da660, 0x1921620, 0xc0002da6a0, 0x1921620)
        /gopath/src/github.com/zrepl/zrepl/rpc/rpc_client.go:53 +0x199
github.com/zrepl/zrepl/daemon/job.(*modePush).ConnectEndpoints(0xc0000d1e90, 0x1921620, 0xc0002da640, 0x1921620, 0xc0002da660, 0x1921620, 0xc0002da6a0, 0x1906f00, 0xc0002d60f0)
        /gopath/src/github.com/zrepl/zrepl/daemon/job/active.go:105 +0x15d
github.com/zrepl/zrepl/daemon/job.(*ActiveSide).do(0xc0000d6120, 0x1918720, 0xc00020f170)
        /gopath/src/github.com/zrepl/zrepl/daemon/job/active.go:356 +0x236
github.com/zrepl/zrepl/daemon/job.(*ActiveSide).Run(0xc0000d6120, 0x1918720, 0xc00009c660)
        /gopath/src/github.com/zrepl/zrepl/daemon/job/active.go:347 +0x289
github.com/zrepl/zrepl/daemon.(*jobs).start.func1(0xc0000fc880, 0x1921620, 0xc0002da120, 0x191a320, 0xc0000d6120, 0x1918720, 0xc0002d6a80)

dist/systemd/zrepl.service

@@ -21,8 +21,10 @@ RestrictRealtime=yes
 SystemCallArchitectures=native
 
 # BEGIN ProtectHome
-ProtectHome=read-only   # DEBIAN STRETCH
+# DEBIAN STRETCH
-# ProtectHome=tmpfs     # FEDORA 28 / 29
+ProtectHome=read-only
+# FEDORA 28 / 29
+# ProtectHome=tmpfs
 # END ProtectHome
 
 # BEGIN SystemCallFilter

docs/changelog.rst

@@ -56,7 +56,8 @@ We use the following annotations for classifying changes:
    |  zrepl is a spare-time project primarily developed by `Christian Schwarz <https://cschwarz.com>`_.
    |  You can support maintenance and feature development through one of the following services:
    |  |Donate via Patreon| |Donate via Liberapay| |Donate via PayPal|
-   |  For commerical support, please `contact Christian directly <https://cschwarz.com>`_.
+   |  Note that PayPal processing fees are relatively high for small donations.
+   |  For SEPA wire transfer and **commerical support**, please `contact Christian directly <https://cschwarz.com>`_.
 
 
 0.1.1

docs/index.rst

@@ -52,7 +52,7 @@ Main Features
 * **Filesystem replication**
 
   * [x] Pull & Push mode
-  * [x] Multiple transport :ref:`transports <transport>`: TCP, TCP + TLS client auth, SSH
+  * [x] Multiple :ref:`transport modes <transport>`: TCP, TCP + TLS client auth, SSH
 
   * Advanced replication features
 

docs/installation.rst

@@ -37,6 +37,9 @@ The following list may be incomplete, feel free to submit a PR with an update:
     * - MacOS
       - ``brew install zrepl``
       - Available on `homebrew <https://brew.sh>`_
+    * - Arch Linux
+      - ``yay install zrepl-bin``
+      - Available on `AUR <https://aur.archlinux.org/packages/zrepl-bin>`_
     * - Others
       -
       - Use `binary releases`_ or build from source.

docs/publish.sh

@@ -55,8 +55,8 @@ set -e
 sphinx-versioning build \
    --show-banner \
    --whitelist-branches '^master$' \
-   --whitelist-tags '(v)?\d+\.\d+\.\d+$' \
+   --whitelist-tags '(v)?\d+\.[1-9][0-9]*.\d+$' \
-   --whitelist-tags '(v)?0.1.0-rc(3|4)$' \
+   --whitelist-tags '(v)?0.2.0-rc.*$' \
    docs ./public_git \
    -- -c sphinxconf # older conf.py throw errors because they used
                     # version = subprocess.show_output(["git", "describe"])

docs/supporters.rst

@@ -6,7 +6,7 @@
 
 zrepl is a spare-time project primarily developed by `Christian Schwarz <https://cschwarz.com>`_.
 You can support maintenance and feature development through one of the services listed above.
-For commerical support, please `contact Christian directly <https://cschwarz.com>`_.
+For SEPA wire transfer and **commerical support**, please `contact Christian directly <https://cschwarz.com>`_.
 
 **Thanks for your support!**
 
@@ -20,6 +20,7 @@ Supporters
 
 We would like to thank the following people / organizations for supporting zrepl through monetary and other means:
 
+* `Marshall Clyburn <https://github.com/mdclyburn>`_
 * `Ross Williams <https://github.com/overhacked>`_
 * Mike T.
 * `Justin Scholz <https://github.com/JMoVS>`_

docs/tutorial.rst

@@ -96,7 +96,7 @@ We define a **push job** named ``prod_to_backups`` in ``/etc/zrepl/zrepl.yml`` o
         key:  /etc/zrepl/prod.key
         server_cn: "backups"
       filesystems: {
-        "zroot/var/db:": true,
+        "zroot/var/db": true,
         "zroot/usr/home<": true,
         "zroot/usr/home/paranoid": false
       }

rpc/grpcclientidentity/grpchelper/authlistener_grpc_adaptor_wrapper.go

@@ -36,9 +36,7 @@ func ClientConn(cn transport.Connecter, log Logger) *grpc.ClientConn {
 	})
 	dialerOption := grpc.WithDialer(grpcclientidentity.NewDialer(log, cn))
 	cred := grpc.WithTransportCredentials(grpcclientidentity.NewTransportCredentials(log))
-	ctx, cancel := context.WithTimeout(context.TODO(), 5*time.Second) // FIXME constant
+	cc, err := grpc.DialContext(context.Background(), "doesn't matter done by dialer", dialerOption, cred, ka)
-	defer cancel()
-	cc, err := grpc.DialContext(ctx, "doesn't matter done by dialer", dialerOption, cred, ka)
 	if err != nil {
 		log.WithError(err).Error("cannot create gRPC client conn (non-blocking)")
 		// It's ok to panic here: the we call grpc.DialContext without the