From f387e2321485021a167a59b212255ff8ff3f4444 Mon Sep 17 00:00:00 2001 From: Anton Schirg Date: Thu, 30 Aug 2018 17:50:43 +0200 Subject: [PATCH] fix: at least two snapshots were needed to start replication --- replication/mainfsm.go | 2 +- zfs/versions.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/replication/mainfsm.go b/replication/mainfsm.go index d30f417..1cae748 100644 --- a/replication/mainfsm.go +++ b/replication/mainfsm.go @@ -211,7 +211,7 @@ func statePlanning(ctx context.Context, sender Sender, receiver Receiver, u upda return handlePlanningError(err) } - if len(sfsvs) <= 1 { + if len(sfsvs) < 1 { err := errors.New("sender does not have any versions") log.Error(err.Error()) q.Add(fsrep.NewReplicationWithPermanentError(fs.Path, err)) diff --git a/zfs/versions.go b/zfs/versions.go index daf5bdc..9deb10d 100644 --- a/zfs/versions.go +++ b/zfs/versions.go @@ -87,7 +87,6 @@ type FilesystemVersionFilter interface { Filter(t VersionType, name string) (accept bool, err error) } -//FIXME Seems to always forget first snapshot func ZFSListFilesystemVersions(fs *DatasetPath, filter FilesystemVersionFilter) (res []FilesystemVersion, err error) { listResults := make(chan ZFSListResult)