From c0a3e1f1210c54350cb8adc5a6cfa7f6f962e0d4 Mon Sep 17 00:00:00 2001 From: Anton Schirg Date: Thu, 30 Aug 2018 17:40:02 +0200 Subject: [PATCH] wrap error in buildJob with job name --- daemon/job/build_jobs.go | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/daemon/job/build_jobs.go b/daemon/job/build_jobs.go index f062918..8843b55 100644 --- a/daemon/job/build_jobs.go +++ b/daemon/job/build_jobs.go @@ -3,6 +3,7 @@ package job import ( "fmt" "github.com/zrepl/zrepl/config" + "github.com/pkg/errors" ) func JobsFromConfig(c config.Config) ([]Job, error) { @@ -18,14 +19,19 @@ func JobsFromConfig(c config.Config) ([]Job, error) { } func buildJob(c config.Global, in config.JobEnum) (j Job, err error) { - switch v := in.Ret.(type) { case *config.SinkJob: - return SinkFromConfig(c, v) + j, err = SinkFromConfig(c, v) + if err != nil { + return nil, errors.Wrapf(err, "cannot build job %q", v.Name) + } case *config.PushJob: - return PushFromConfig(c, v) + j, err = PushFromConfig(c, v) + if err != nil { + return nil, errors.Wrapf(err, "cannot build job %q", v.Name) + } default: panic(fmt.Sprintf("implementation error: unknown job type %T", v)) } - + return j, err }