add platformtest: infrastructure for ZFS compatiblity testing

platformtest/tests/batchDestroy.go

@@ -0,0 +1,54 @@
+package tests
+
+import (
+	"fmt"
+	"strings"
+
+	"github.com/zrepl/zrepl/platformtest"
+	"github.com/zrepl/zrepl/zfs"
+)
+
+func BatchDestroy(ctx *platformtest.Context) {
+
+	platformtest.Run(ctx, platformtest.PanicErr, ctx.RootDataset, `
+		DESTROYROOT
+		CREATEROOT
+		+  "foo bar"
+		+  "foo bar@1"
+		+  "foo bar@2"
+		+  "foo bar@3"
+		R  zfs hold zrepl_platformtest "${ROOTDS}/foo bar@2"
+	`)
+
+	reqs := []*zfs.DestroySnapOp{
+		&zfs.DestroySnapOp{
+			ErrOut:     new(error),
+			Filesystem: fmt.Sprintf("%s/foo bar", ctx.RootDataset),
+			Name:       "3",
+		},
+		&zfs.DestroySnapOp{
+			ErrOut:     new(error),
+			Filesystem: fmt.Sprintf("%s/foo bar", ctx.RootDataset),
+			Name:       "2",
+		},
+	}
+	zfs.ZFSDestroyFilesystemVersions(reqs)
+	if *reqs[0].ErrOut != nil {
+		panic("expecting no error")
+	}
+	err := (*reqs[1].ErrOut).Error()
+	if !strings.Contains(err, fmt.Sprintf("%s/foo bar@2", ctx.RootDataset)) {
+		panic(fmt.Sprintf("expecting error about being unable to destroy @2: %T\n%s", err, err))
+	}
+
+	platformtest.Run(ctx, platformtest.PanicErr, ctx.RootDataset, `
+	!N "foo bar@3"
+	!E "foo bar@1"
+	!E "foo bar@2"
+	R zfs release zrepl_platformtest "${ROOTDS}/foo bar@2"
+	-  "foo bar@2"
+	-  "foo bar@1"
+	-  "foo bar"
+	`)
+
+}

platformtest/tests/getNonexistent.go

@@ -0,0 +1,54 @@
+package tests
+
+import (
+	"fmt"
+
+	"github.com/zrepl/zrepl/platformtest"
+	"github.com/zrepl/zrepl/zfs"
+)
+
+func GetNonexistent(ctx *platformtest.Context) {
+
+	platformtest.Run(ctx, platformtest.PanicErr, ctx.RootDataset, `
+		DESTROYROOT
+		CREATEROOT
+		+  "foo bar"
+		+  "foo bar@1"
+	`)
+	defer platformtest.Run(ctx, platformtest.PanicErr, ctx.RootDataset, `
+		DESTROYROOT
+	`)
+
+	// test raw
+	_, err := zfs.ZFSGetRawAnySource(fmt.Sprintf("%s/foo bar", ctx.RootDataset), []string{"name"})
+	if err != nil {
+		panic(err)
+	}
+
+	// test nonexistent filesystem
+	nonexistent := fmt.Sprintf("%s/nonexistent filesystem", ctx.RootDataset)
+	props, err := zfs.ZFSGetRawAnySource(nonexistent, []string{"name"})
+	if err == nil {
+		panic(props)
+	}
+	dsne, ok := err.(*zfs.DatasetDoesNotExist)
+	if !ok {
+		panic(err)
+	} else if dsne.Path != nonexistent {
+		panic(err)
+	}
+
+	// test nonexistent snapshot
+	nonexistent = fmt.Sprintf("%s/foo bar@non existent", ctx.RootDataset)
+	props, err = zfs.ZFSGetRawAnySource(nonexistent, []string{"name"})
+	if err == nil {
+		panic(props)
+	}
+	dsne, ok = err.(*zfs.DatasetDoesNotExist)
+	if !ok {
+		panic(err)
+	} else if dsne.Path != nonexistent {
+		panic(err)
+	}
+
+}

platformtest/tests/tests.go

@@ -0,0 +1,20 @@
+package tests
+
+import (
+	"reflect"
+	"runtime"
+
+	"github.com/zrepl/zrepl/platformtest"
+)
+
+type Case func(*platformtest.Context)
+
+func (c Case) String() string {
+	return runtime.FuncForPC(reflect.ValueOf(c).Pointer()).Name()
+}
+
+var Cases = []Case{
+	BatchDestroy,
+	UndestroyableSnapshotParsing,
+	GetNonexistent,
+}

platformtest/tests/undestroyableSnapshotParsing.go

@@ -0,0 +1,40 @@
+package tests
+
+import (
+	"fmt"
+
+	"github.com/stretchr/testify/require"
+	"github.com/zrepl/zrepl/platformtest"
+	"github.com/zrepl/zrepl/zfs"
+)
+
+func UndestroyableSnapshotParsing(t *platformtest.Context) {
+	platformtest.Run(t, platformtest.PanicErr, t.RootDataset, `
+		DESTROYROOT
+		CREATEROOT
+		+  "foo bar"
+		+  "foo bar@1 2 3"
+		+  "foo bar@4 5 6"
+		+  "foo bar@7 8 9"
+		R  zfs hold zrepl_platformtest "${ROOTDS}/foo bar@4 5 6"
+	`)
+	defer platformtest.Run(t, platformtest.PanicErr, t.RootDataset, `
+	R zfs release zrepl_platformtest "${ROOTDS}/foo bar@4 5 6"
+	DESTROYROOT
+	`)
+
+	err := zfs.ZFSDestroy(fmt.Sprintf("%s/foo bar@1 2 3,4 5 6,7 8 9", t.RootDataset))
+	if err == nil {
+		panic("expecting destroy error due to hold")
+	}
+	if dse, ok := err.(*zfs.DestroySnapshotsError); !ok {
+		panic(fmt.Sprintf("expecting *zfs.DestroySnapshotsError, got %T\n%v\n%s", err, err, err))
+	} else {
+		if dse.Filesystem != fmt.Sprintf("%s/foo bar", t.RootDataset) {
+			panic(dse.Filesystem)
+		}
+		require.Equal(t, []string{"4 5 6"}, dse.Undestroyable)
+		require.Equal(t, []string{"dataset is busy"}, dse.Reason)
+	}
+
+}