From 79118ada70ffb16192c9116f86b7231f0756b641 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Sun, 15 Feb 2026 18:48:04 +0000 Subject: [PATCH] release: details on how to get right number for artifact download script --- Makefile | 2 +- README.md | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 2bf3506..c185cc5 100644 --- a/Makefile +++ b/Makefile @@ -222,7 +222,7 @@ clean: docs-clean download-circleci-release: rm -rf "$(ARTIFACTDIR)" mkdir -p "$(ARTIFACTDIR)/release" - python3 .circleci/download_artifacts.py --prefix 'artifacts/release/' "$(BUILD_NUM)" "$(ARTIFACTDIR)/release" + python3 .circleci/download_artifacts.py --prefix 'artifacts/release/' "$(JOB_NUM)" "$(ARTIFACTDIR)/release" ##################### MULTI-ARCH HELPERS ##################### diff --git a/README.md b/README.md index f06c549..b230f0b 100644 --- a/README.md +++ b/README.md @@ -104,9 +104,13 @@ The procedure to issue a release is as follows: * Run the `release` pipeline against the `master` branch (trigger via CircleCI UI). This URL: https://app.circleci.com/pipelines/github/zrepl/zrepl?branch=master. Example pipeline: https://app.circleci.com/pipelines/github/zrepl/zrepl/8547 - * Download artifacts: + * Download artifacts using this handy makefile target. + Note: `JOB_NUM` must be the **job number** from the `release-upload` job, **not the pipeline number**. + Find it via: pipeline → `release` workflow → `release-upload` job number. + Example URL: https://app.circleci.com/pipelines/github/zrepl/zrepl/8547/workflows/65feb2c9-15d7-46ab-a551-46d62a5769b0/jobs/66079/steps + ``` - make download-circleci-release BUILD_NUM=8547 + make download-circleci-release JOB_NUM=66079 ``` * Create GitHub release and upload artifacts: ```bash