From 44d20ac256ec6b9d0253842d7049ad96310176d7 Mon Sep 17 00:00:00 2001
From: Christian Schwarz <me@cschwarz.com>
Date: Sat, 6 May 2017 23:45:33 +0200
Subject: [PATCH] zfs: ZFSListMapping fix broken logic

---
 zfs/mapping.go | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/zfs/mapping.go b/zfs/mapping.go
index 5911e38..b9feb66 100644
--- a/zfs/mapping.go
+++ b/zfs/mapping.go
@@ -21,9 +21,9 @@ func ZFSListMapping(mapping DatasetMapping) (datasets []DatasetPath, err error)
 	var lines [][]string
 	lines, err = ZFSList([]string{"name"}, "-r", "-t", "filesystem,volume")
 
-	datasets = make([]DatasetPath, len(lines))
+	datasets = make([]DatasetPath, 0, len(lines))
 
-	for i, line := range lines {
+	for _, line := range lines {
 
 		var path DatasetPath
 		if path, err = NewDatasetPath(line[0]); err != nil {
@@ -31,12 +31,12 @@ func ZFSListMapping(mapping DatasetMapping) (datasets []DatasetPath, err error)
 		}
 
 		_, mapErr := mapping.Map(path)
-		if mapErr != nil && err != NoMatchError {
-			return nil, err
+		if mapErr != nil && mapErr != NoMatchError {
+			return nil, mapErr
 		}
 
 		if mapErr == nil {
-			datasets[i] = path
+			datasets = append(datasets, path)
 		}
 
 	}