platformtest: harness: -failure.stop-and-keep-pool mode, prettier logging

platformtest/harness/harness.go

@@ -19,12 +19,14 @@ import (
 func main() {
 
 	var args struct {
-		createArgs platformtest.ZpoolCreateArgs
+		createArgs            platformtest.ZpoolCreateArgs
+		stopAndKeepPoolOnFail bool
 	}
 	flag.StringVar(&args.createArgs.PoolName, "poolname", "", "")
 	flag.StringVar(&args.createArgs.ImagePath, "imagepath", "", "")
 	flag.Int64Var(&args.createArgs.ImageSize, "imagesize", 100*(1<<20), "")
 	flag.StringVar(&args.createArgs.Mountpoint, "mountpoint", "none", "")
+	flag.BoolVar(&args.stopAndKeepPoolOnFail, "failure.stop-and-keep-pool", false, "if a test case fails, stop test execution and keep pool as it was when the test failed")
 	flag.Parse()
 
 	outlets := logger.NewOutlets()
@@ -52,13 +54,21 @@ func main() {
 	boldGreen := color.New(color.Bold, color.FgHiGreen)
 	for _, c := range tests.Cases {
 		// ATTENTION future parallelism must pass c by value into closure!
-		err := func() error {
+		err := func() (err error) {
+			var oErr = &err
 			bold.Printf("BEGIN TEST CASE %s\n", c)
 			pool, err := platformtest.CreateOrReplaceZpool(ctx, ex, args.createArgs)
 			if err != nil {
 				return errors.Wrap(err, "create test pool")
 			}
 			defer func() {
+				if err := recover(); err != nil {
+					*oErr = errors.Errorf("panic while running test: %v", err) // shadow
+					if args.stopAndKeepPoolOnFail {
+						return
+					}
+					// fallthrough
+				}
 				if err := pool.Destroy(ctx, ex); err != nil {
 					fmt.Printf("error destroying test pool: %s", err)
 				}
@@ -72,6 +82,11 @@ func main() {
 		}()
 		if err != nil {
 			boldRed.Printf("TEST CASE FAILED WITH ERROR:\n")
+			fmt.Printf("%+v\n", err) // print with stack trace
+			if args.stopAndKeepPoolOnFail {
+				bold.Printf("STOPPING TEST RUN AT FAILING TEST PER USER REQUEST\n")
+				return
+			}
 		} else {
 			boldGreen.Printf("DONE  TEST CASE %s\n", c)
 		}